Fix Atis encryption, fix avatars, fix atis reminder location#40
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements ATIS encryption, fixes Discord avatar display in the ACARS sidebar, and relocates the ATIS reminder modal from the Flights page to the Create page. The changes enhance security by encrypting ATIS data at rest while maintaining functionality through proper encryption/decryption in the backend routes and websocket handlers. User experience improvements include fixing avatar URLs and showing the ATIS format reminder at session creation time for PFATC networks.
Key changes:
- ATIS data encryption/decryption across backend endpoints and websockets
- Discord avatar URL construction and display in ACARS sidebar and overview
- ATIS reminder modal moved from Flights page to Create page with proper state management
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/routes/atis.ts | Encrypts ATIS data before storing and updates response field names |
| server/routes/sessions.ts | Adds encryption/decryption for ATIS in GET and PUT endpoints |
| server/websockets/sessionUsersWebsocket.ts | Implements ATIS encryption/decryption in websocket handlers |
| server/websockets/overviewWebsocket.ts | Constructs Discord avatar URLs for controllers |
| src/pages/Create.tsx | Adds ATIS reminder modal display after session creation for PFATC |
| src/pages/Flights.tsx | Removes ATIS reminder modal and adds position-based departure filtering |
| src/components/acars/AcarsSidebar.tsx | Uses avatar field from controller data for display |
| src/components/acars/AcarsTerminal.tsx | Adds timestamp and station labels to terminal messages |
| src/components/acars/AcarsChartDrawer.tsx | Refactors image loading state with useEffect |
| src/components/modals/AtisReminderModal.tsx | Updates modal styling with gradient background |
| src/sockets/overviewSocket.ts | Adds optional avatar field to controller interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend Security Enhancements
server/routes/atis.ts,server/routes/sessions.ts, and websocket handlers inserver/websockets/sessionUsersWebsocket.ts. [1] [2] [3] [4] [5] [6] [7] [8] [9]Frontend User Experience Improvements
src/pages/Create.tsxand uses the newAtisReminderModalcomponent. [1] [2] [3] [4]UI and Display Refinements
Minor Frontend Adjustments
AcarsChartDraweris now managed using auseEffecthook, and redundantonLoadStarthandlers are removed for cleaner image loading logic. [1] [2] [3] [4]src/pages/Flights.tsxfor code cleanliness. [1] [2]